From dee764eb311089d398ec273e2d523f16ccb005f6 Mon Sep 17 00:00:00 2001
From: j37hr0 <jethro.cotton3@gmail.com>
Date: Mon, 27 Apr 2026 15:37:16 +1200
Subject: [PATCH] update db init script to put create databse outside of
 transaction

---
 infrastructure/modules/postgres-app/job.yaml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/infrastructure/modules/postgres-app/job.yaml b/infrastructure/modules/postgres-app/job.yaml
index e747087..78b4f31 100644
--- a/infrastructure/modules/postgres-app/job.yaml
+++ b/infrastructure/modules/postgres-app/job.yaml
@@ -43,6 +43,7 @@ spec:
         - -c
         - |
           psql <<EOF
+          -- Create user (safe in transaction)
           DO \$\$
           BEGIN
             IF NOT EXISTS (SELECT FROM pg_roles WHERE rolname = '${APP_USER}') THEN
@@ -51,13 +52,12 @@ spec:
           END
           \$\$;
 
-          DO \$\$
-          BEGIN
-            IF NOT EXISTS (SELECT FROM pg_database WHERE datname = '${APP_DB}') THEN
-              CREATE DATABASE ${APP_DB} OWNER ${APP_USER};
-            END IF;
-          END
-          \$\$;
+          -- Create database (must be outside transaction)
+          SELECT 'CREATE DATABASE ${APP_DB} OWNER ${APP_USER}'
+          WHERE NOT EXISTS (
+            SELECT FROM pg_database WHERE datname = '${APP_DB}'
+          )\gexec
 
+          -- Grant privileges (safe)
           GRANT ALL PRIVILEGES ON DATABASE ${APP_DB} TO ${APP_USER};
           EOF